Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FST reader update to support new Kaldi versions #39

Merged
merged 1 commit into from
Jul 24, 2018
Merged

FST reader update to support new Kaldi versions #39

merged 1 commit into from
Jul 24, 2018

Conversation

mdoulaty
Copy link
Contributor

https://groups.google.com/d/msg/kaldi-help/0SuCkeHyUmU/SogcAuWbBQAJ
New Kaldi versions have an updated FST reader

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@mdoulaty mdoulaty mentioned this pull request Jul 22, 2018
@mdoulaty
Copy link
Contributor Author

this should solve #34

@realill
Copy link
Contributor

realill commented Jul 23, 2018

Does it still work with older FST format? Like this one https://github.com/dialogflow/api-ai-english-asr-model ?

@mdoulaty
Copy link
Contributor Author

yes, it does

@mdoulaty
Copy link
Contributor Author

the pre-trained models that you mentioned (https://github.com/dialogflow/api-ai-english-asr-model), works as expected after this change

@realill realill merged commit d551d7a into dialogflow:master Jul 24, 2018
@realill
Copy link
Contributor

realill commented Jul 24, 2018

Merged. Thanks.

@mdoulaty mdoulaty deleted the patch-1 branch July 24, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants