-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected behavior with some auto advance setting #2190
Comments
Yeah I could also fix autoadvance of 0 not working, although I agree that it likely has very few use-cases. |
If we don't want to allow 0 it should have a red outline and display some warning, and if we want it but it is not technically possible we can always make it be |
Actually I think I would just allow it and fix the bug. Having the delay at 0 is usually stupid, but I'm sure there are situations where it might make sense, especially when used with the autoadvance effect, for example if it should look as if someone was interrupted. |
- should fix dialogic-godot#2190
The problem
Describe the bug
The auto advance settings are a bit misleading and can cause confusion as certain settings don't work as you'd expect. The issue we found involved
Base Delay: 0
Additional Delay: None
Enabled: True
The expected result to me and others would be that the text would auto advance after the text finishes appearing with no additional delay. But what happens is no auto advance occurs at all. However if you add even .01 to the base delay or add some sort of additional delay, it works fine.
In general you probably DO want some delay in an auto advance, but in that case we shouldn't allow the combination of base delay 0, additional delay none to exist.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
That the timeline will autoadvance, though to fast to read for most people.
System (please complete the following information):
Solutions
Workaround
Adding any amount to base delay, or an additional delay fixes it.
Possible fixes
Easiest fix is to not allow a base delay of 0.
The text was updated successfully, but these errors were encountered: