Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pause] command clashes with skipping text #775

Closed
Jowan-Spooner opened this issue Feb 17, 2022 · 0 comments
Closed

[pause] command clashes with skipping text #775

Jowan-Spooner opened this issue Feb 17, 2022 · 0 comments
Labels
Bug 🐞 Something isn't working
Milestone

Comments

@Jowan-Spooner
Copy link
Collaborator

The problem

Describe the bug
If you hit the action key to skip the text animation while the TextBubble handles a [pause] command, it will continue the animation ones the pause is finished. This means some text will hide again and the animation is shown, although you skipped already.

In questions this can even lead to having all choices TWICE on screen, because the _on_text_finished() function is executed twice.

To Reproduce
Steps to reproduce the behavior:

  1. Create a text event that has a [pause = 2] command in it.
  2. Play the game
  3. While the text pauses, hit ENTER once
  4. See the text shortly
  5. Then see the animation continue where it stopped

Expected behavior
No more animating.

@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Feb 17, 2022
@Jowan-Spooner Jowan-Spooner added this to the Version 1.4 milestone Feb 17, 2022
Jowan-Spooner added a commit to Jowan-Spooner/dialogic that referenced this issue Feb 17, 2022
Jowan-Spooner added a commit that referenced this issue Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant