Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1499 #1501

Merged
merged 6 commits into from
Apr 2, 2023
Merged

Fix for #1499 #1501

merged 6 commits into from
Apr 2, 2023

Conversation

Jowan-Spooner
Copy link
Collaborator

@Jowan-Spooner Jowan-Spooner commented Apr 2, 2023

Fix for string values not being assigned correctly in Set variable event.

_save() is now called even if the editor is not of type resource. This makes sure that for examples variables are correctly saved before starting a debug game and when hitting CTRL+S.
- Also give character instead of character name in Dialogic.Text.speaking_character signal
Strings weren't correctly identified in the set variable event execution.
@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Apr 2, 2023
@Jowan-Spooner Jowan-Spooner merged commit 3c2845e into main Apr 2, 2023
@Jowan-Spooner Jowan-Spooner deleted the fix-string-variable branch April 19, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Variable Doesnt Work
1 participant