Portrait modes update (+other stuff) #1591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Character portrait modes
... have been removed! Hurray!
Seriously tho. Instead portrait containers can now choose between two modes: Position and Speaker.
-> this means both modes can now be used at the same time
-> it also means that this is now dependent on the layout scenes setup (no external setting)
To make this work I had to rewrite a lot of the portrait subsystems methods.
This means there is now a set of methods that allow manipulating a portrait based on the actual portrait node (not the character). There is also another set of methods for the position mode (VN-style portaits; used by the character event). These methods will make sure the character is joined and wont allow duplicate characters. A join_character(), leave_character() methods have been added to make character event functionality more accessable. The second set of methods uses the first under the hood (with extra checks and functionality around).
Other changes
Along the way numerous other things have been fixed...