Speaker highlight improvements #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This offloads a lot of the work for simple Sprite and TextureRect based portraits a lot easier by having helper methods on the portrait do that work. This will allow us to make more variations of these kinds of portraits very easily.
Also small jump suggestions change.
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* Fix simple-string portraits * Fix _highlight & _unhighlight and make custom portrait easier This offloads a lot of the work for simple Sprite and TextureRect based portraits a lot easier by having helper methods on the portrait do that work. This will allow us to make more variations of these kinds of portraits very easily. * Example Custom Portrait with Highlighting Also small jump suggestions change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Importing portraits from folders
moves a bunch of code into the DialogicPortrait class so simple custom portraits are easier to create.
makes it so _unhighlight is called if noone speaks.
adds a example custom portrait scene that can highlight and bring the speaker to the front