Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/background holder dangling reference #1958

Conversation

Pheubel
Copy link
Contributor

@Pheubel Pheubel commented Dec 16, 2023

Fixes #1957
additionally, adds more explanation in order to create clarity for #1946

@Jowan-Spooner
Copy link
Collaborator

Lgtm. Thanks!

@Jowan-Spooner Jowan-Spooner merged commit 8f21e25 into dialogic-godot:main Dec 19, 2023
Invertex pushed a commit to Invertex/dialogic that referenced this pull request Jan 26, 2024
* remove current viewport meta when no new instance is available

* made error a bit more verbose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background holder has dangling reference to removed viewport
2 participants