Extend DialogicPortrait by custom portraits.
#2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure this works without the scripts needing any adjustments? |
|
I can test a bit more. |
|
|
||
| # if implemented, this is used by the editor for the "full view" mode | ||
| func _set_mirror(is_mirrored: bool) -> void: | ||
| var nd: Node2D = get_parent().get_child(0) |
There was a problem hiding this comment.
I think this should work by just accessing the scale as self.scale instead of this workaround.
|
Thank you. |
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* Extend `DialogicPortrait` by custom portraits. * Fix root name's extra `s`. * Format and fix errors. * Simplify by using `self`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
DialogicPortraiton custom portraits in the custom assets.This prevents errors when a method like
_highlightis invoked.