Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Documentation improvements #2117

Merged
merged 14 commits into from
Feb 27, 2024
Merged

Small Documentation improvements #2117

merged 14 commits into from
Feb 27, 2024

Conversation

Jowan-Spooner
Copy link
Collaborator

No description provided.

@Jowan-Spooner Jowan-Spooner added Documentation 📚 Improvements or additions to documentation Enhance ⚡ Improve a feature's workflow. labels Feb 26, 2024
CakeVR
CakeVR requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@CakeVR CakeVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provides some suggestions and a few comments on code passages.
There was one undocumented public GDScript item I found.

You can accept the suggestions, if you agree with them. If you have questions, please feel free to ask me.

addons/dialogic/Core/DialogicGameHandler.gd Outdated Show resolved Hide resolved
addons/dialogic/Core/DialogicGameHandler.gd Outdated Show resolved Hide resolved
addons/dialogic/Core/DialogicGameHandler.gd Outdated Show resolved Hide resolved
addons/dialogic/Core/DialogicGameHandler.gd Outdated Show resolved Hide resolved
addons/dialogic/Core/DialogicGameHandler.gd Show resolved Hide resolved
addons/dialogic/Core/DialogicGameHandler.gd Outdated Show resolved Hide resolved
addons/dialogic/Core/DialogicGameHandler.gd Outdated Show resolved Hide resolved
addons/dialogic/Core/DialogicResourceUtil.gd Outdated Show resolved Hide resolved
addons/dialogic/Core/DialogicResourceUtil.gd Show resolved Hide resolved
addons/dialogic/Core/DialogicResourceUtil.gd Outdated Show resolved Hide resolved
Jowan-Spooner and others added 12 commits February 27, 2024 12:26
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
929ddde 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
f7f886c 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
4b3ce43 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
1ee7ae6 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
06751b0 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
c3c81e9 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
803117c 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
0920a46 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner
Improve DGH docs
b1b55cb
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicGameHandler.gd
4326d45 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicResourceUtil.gd
504f496 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner @CakeVR
Update addons/dialogic/Core/DialogicResourceUtil.gd
5e5d124 
Co-authored-by: Cake <65981767+CakeVR@users.noreply.github.com>
@Jowan-Spooner Jowan-Spooner merged commit 2472d74 into dialogic-godot:main Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CakeVR CakeVR CakeVR approved these changes

Assignees
No one assigned
Labels
Documentation 📚 Improvements or additions to documentation Enhance ⚡ Improve a feature's workflow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jowan-Spooner @CakeVR