Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ConditionPicker#is_too_complex #2138

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

iscke
Copy link
Contributor

@iscke iscke commented Mar 12, 2024

Currently, is_too_complex requires condition.count('==') == 1 and condition.count('>') != 1 etc for a condition to be complex, meaning you need something like == != <= >= in your expression for it to be counted as complex. This changes the requirement to being empty or having a single comparison operator, which is closer to what the simple condition editor and complex2simple use.

@iscke
Copy link
Contributor Author

iscke commented Mar 12, 2024

(the specific issue i've encountered with this is if you write a condition that's not parsable by complex2simple, like SomeGlobal.returns_a_bool() and then restart your editor, Dialogic sees it as a simple condition and then fails to convert it back, turning it into the blank == simple condition.)

@Jowan-Spooner
Copy link
Collaborator

Thanks, looks good to me!

@Jowan-Spooner Jowan-Spooner merged commit aca983b into dialogic-godot:main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants