Audio event bus management simplification #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows code like this, to change the default bus for music, without changing the event default: `Dialogic.Audio.base_music_player.bus = "Music"` *Same for sounds.* Previously it would always default to the "Master" bus, except if you changed the event default. You can still change the event default to overwrite this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Music and Sound events will now default to "" as their bus, and when given an empty bus won't change the bus of the default_music_player or default_sound_player.
This allows code like this, to change the default bus, without changing the event default:
Dialogic.Audio.base_music_player.bus = "Music"Same for sounds.
Previously it would always default to the "Master" bus, except if you changed the event default. Assigning a default to the event in the modules manager still overwrites this. And both default audio players also still default to Master, so this does not break compat.