New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreation of History Functionality #625
Merged
Jowan-Spooner
merged 70 commits into
dialogic-godot:main
from
zaknafean:History-Timeline
Feb 3, 2022
Merged
Recreation of History Functionality #625
Jowan-Spooner
merged 70 commits into
dialogic-godot:main
from
zaknafean:History-Timeline
Feb 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for dialogic-godot#454 New regular expression added to escape regular expression characters that could appear in a name.
Cleaned up the messes and fixed the known bugs. I think we're good for a review here! |
Suggestions (as already discussed):
|
Added a default GODOT theme to Open and Close buttons
Testing looks good, and ready for review |
Reduced visual clutter if not using History Settings
Tweaked visuals of HistorySettings
Fixed mis-sized'audio playback' button Changed default placeholder icon from character to text icon Removed obsolete code
Allow mouse clicks to pass through History window.
Fixed the starting state of the record_history boolean Fixed a crash when leave-all is logged
Removed the 'dynamic theme' logging Removed placeholder button icon for non audio events Fixed default margin settings
Fixed 2 bugs related to default settings on 1st time run
removed historysettings to more easily merge again
Fixed a bug where name was ignored in favor of displayname
Button position now saves as a string
Changed the HistoryPopup to be a container rather than a Popup for better click control.
Updated logic to handle the new way join/leave works. Fixed a bug where arrival/exit text didnt' save on change.
Added an exclusion for character join/leave/update to not log anything on 'update'
changed position of this
Fixed typo in logging exclusion logic Changed 'HistoryPopup' node type to not override margin settings
Changed defaults to start at full screen
Fixed logging LEAVES or ARRIVALS Fixed a bug when EVERYONE leaves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned version of PR#591