Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreation of History Functionality #625

Merged
merged 70 commits into from Feb 3, 2022

Conversation

zaknafean
Copy link
Collaborator

Cleaned version of PR#591

@zaknafean
Copy link
Collaborator Author

Back to about where I was previously, but with all the new merges and cleaner code.
Summary of the Changes as follows:
Settings.tscn/Settings.gd
image
This and the code to make that work.

History.tscn/History.gd
Bulk of the new code and functionality is encapsulated here

HistoryRow.tscn/HistoryRow.gd
Helper node for History. A new history row is created whenever something is logged. This is a separate node so that advanced users can clone and customize it to their hearts content if they so desire

DialogNode.tscn
Added the History node to this

DialogNode.gd
Added logging statements. Added initial theme loading

Testing:
Fresh install of my branch in a new project. History starts disabled, upon enabling functoins as expected.

Known issue:
Currently if you use mouse click to advance dialog, the history will pop up AND the dialog will advance. This can likely be fixed with a new History state, but I wanted to get this part done before I muck with DialogNode more.

@zaknafean
Copy link
Collaborator Author

Cleaned up the messes and fixed the known bugs. I think we're good for a review here!

@Jowan-Spooner
Copy link
Collaborator

Jowan-Spooner commented Nov 24, 2021

Suggestions (as already discussed):

  • History close button says "Test" right now
  • If you use a definition as the player display name it doesn't get replaced correctly. My players name is defined by the [PLAYER_NICKNAME] definition and in game it says "John" but in the History it says [PLAYER_NICKNAME].
  • easily customize phrases like "has arrived" (remove the : for these?)
  • Option to disable the "showing all options" for questions
  • Options for what should be logged and showed
  • Disabling of default open and close buttons (separately as buttons inside a popup can be difficult to get right)

@zaknafean
Copy link
Collaborator Author

Still alive! Got all the discussed upgrades aside from the nickname bug fix, which shouldn't actually be too bad. Will check in after a clean test tomorrow. Preview of new options... its busy unfortunately, but I think any good logging system is always a bit more complex than one would like.

image

Added a default GODOT theme to Open and Close buttons
@zaknafean
Copy link
Collaborator Author

Testing looks good, and ready for review

zaknafean and others added 26 commits January 15, 2022 09:12
Reduced visual clutter if not using History Settings
Tweaked visuals of HistorySettings
Fixed mis-sized'audio playback' button
Changed default placeholder icon from character to text icon
Removed obsolete code
Allow mouse clicks to pass through History window.
Fixed the starting state of the record_history boolean
Fixed a crash when leave-all is logged
Removed the 'dynamic theme' logging
Removed placeholder button icon for non audio events
Fixed default margin settings
Fixed 2 bugs related to default settings on 1st time run
removed historysettings to more easily merge again
Fixed a bug where name was ignored in favor of displayname
Button position now saves as a string
Changed the HistoryPopup to be a container rather than a Popup for better click control.
Updated logic to handle the new way join/leave works.
Fixed a bug where arrival/exit text didnt' save on change.
Added an exclusion for character join/leave/update to not log anything on 'update'
changed position of this
Fixed typo in logging exclusion logic
Changed 'HistoryPopup' node type to not override margin settings
Changed defaults to start at full screen
Fixed logging LEAVES or ARRIVALS
Fixed a bug when EVERYONE leaves
@Jowan-Spooner Jowan-Spooner merged commit ba04773 into dialogic-godot:main Feb 3, 2022
@zaknafean zaknafean deleted the History-Timeline branch April 11, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants