Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Theme per Character #680

Merged
merged 5 commits into from Dec 29, 2021

Conversation

Jowan-Spooner
Copy link
Collaborator

You can now select a theme for each character.
If the character says something the theme will be loaded. If then a character without a custom theme will says anything, it will go back to the current theme.

An implementation of #231.

You can now select a theme for each character. 
If the character says something the theme will be loaded. If then a character without a custom theme will says anything, it will go back to the current theme.
@zaknafean
Copy link
Collaborator

Bug Report:

  1. If you delete a theme that's in use by a character, it breaks weirdly. The characters theme field will correctly say 'No custom theme' but your game will crash when it gets to that character until you choose a new theme. That fixes it, but even restarting Godot doesn't otherwise fix it.
  2. There doesn't appear to be a way to remove themes once you choose a custom theme

So far thats it! I'll see if I can't dig more bugs out of it.

@Jowan-Spooner
Copy link
Collaborator Author

@coppolaemilio if you don't test this soon, I'll just merge it!

@coppolaemilio coppolaemilio merged commit b101fe5 into dialogic-godot:main Dec 29, 2021
@Jowan-Spooner Jowan-Spooner deleted the character-theme branch March 1, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants