Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use DeclarativeBase - DIA-55287 #92

Merged
merged 2 commits into from
May 5, 2023

Conversation

hadrien
Copy link
Member

@hadrien hadrien commented May 5, 2023

Description

  • Use DeclarativeBase

Related JIRA issues

Related PRs

Validation

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #92 (370c1af) into master (5810159) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          403       404    +1     
  Branches        52        52           
=========================================
+ Hits           403       404    +1     
Flag Coverage Δ
python_version3.10-sqlalchemy1.3-asyncpg-aws_rds_iam 65.59% <100.00%> (+0.08%) ⬆️
python_version3.10-sqlalchemy1.3-asyncpg-noaws_rds_iam 63.61% <100.00%> (+0.09%) ⬆️
python_version3.10-sqlalchemy1.3-noasyncpg-aws_rds_iam 65.34% <100.00%> (+0.08%) ⬆️
python_version3.10-sqlalchemy1.3-noasyncpg-noaws_rds_iam 63.36% <100.00%> (+0.09%) ⬆️
python_version3.10-sqlalchemy1.4-asyncpg-aws_rds_iam 96.78% <100.00%> (+0.50%) ⬆️
python_version3.10-sqlalchemy1.4-asyncpg-noaws_rds_iam 94.80% <100.00%> (+0.50%) ⬆️
python_version3.10-sqlalchemy1.4-noasyncpg-aws_rds_iam 77.72% <100.00%> (+0.55%) ⬆️
python_version3.10-sqlalchemy1.4-noasyncpg-noaws_rds_iam 75.74% <100.00%> (+0.55%) ⬆️
python_version3.10-sqlalchemy2.0-asyncpg-aws_rds_iam 96.03% <66.66%> (-0.24%) ⬇️
python_version3.10-sqlalchemy2.0-asyncpg-noaws_rds_iam 94.05% <66.66%> (-0.24%) ⬇️
python_version3.10-sqlalchemy2.0-noasyncpg-aws_rds_iam 76.98% <66.66%> (-0.20%) ⬇️
python_version3.10-sqlalchemy2.0-noasyncpg-noaws_rds_iam 75.00% <66.66%> (-0.19%) ⬇️
python_version3.11-sqlalchemy1.3-asyncpg-aws_rds_iam 65.59% <100.00%> (+0.08%) ⬆️
python_version3.11-sqlalchemy1.3-asyncpg-noaws_rds_iam 63.61% <100.00%> (+0.09%) ⬆️
python_version3.11-sqlalchemy1.3-noasyncpg-aws_rds_iam 65.34% <100.00%> (+0.08%) ⬆️
python_version3.11-sqlalchemy1.3-noasyncpg-noaws_rds_iam 63.36% <100.00%> (+0.09%) ⬆️
python_version3.11-sqlalchemy1.4-asyncpg-aws_rds_iam 96.78% <100.00%> (+0.50%) ⬆️
python_version3.11-sqlalchemy1.4-asyncpg-noaws_rds_iam 94.80% <100.00%> (+0.50%) ⬆️
python_version3.11-sqlalchemy1.4-noasyncpg-aws_rds_iam 77.72% <100.00%> (+0.55%) ⬆️
python_version3.11-sqlalchemy1.4-noasyncpg-noaws_rds_iam 75.74% <100.00%> (+0.55%) ⬆️
python_version3.11-sqlalchemy2.0-asyncpg-aws_rds_iam 96.03% <66.66%> (-0.24%) ⬇️
python_version3.11-sqlalchemy2.0-asyncpg-noaws_rds_iam 94.05% <66.66%> (-0.24%) ⬇️
python_version3.11-sqlalchemy2.0-noasyncpg-aws_rds_iam 76.98% <66.66%> (-0.20%) ⬇️
python_version3.11-sqlalchemy2.0-noasyncpg-noaws_rds_iam 75.00% <66.66%> (-0.19%) ⬇️
python_version3.9-sqlalchemy1.3-asyncpg-aws_rds_iam 65.59% <100.00%> (+0.08%) ⬆️
python_version3.9-sqlalchemy1.3-asyncpg-noaws_rds_iam 63.61% <100.00%> (+0.09%) ⬆️
python_version3.9-sqlalchemy1.3-noasyncpg-aws_rds_iam 65.34% <100.00%> (+0.08%) ⬆️
python_version3.9-sqlalchemy1.3-noasyncpg-noaws_rds_iam 63.36% <100.00%> (+0.09%) ⬆️
python_version3.9-sqlalchemy1.4-asyncpg-aws_rds_iam 96.78% <100.00%> (+0.50%) ⬆️
python_version3.9-sqlalchemy1.4-asyncpg-noaws_rds_iam 94.80% <100.00%> (+0.50%) ⬆️
python_version3.9-sqlalchemy1.4-noasyncpg-aws_rds_iam 77.72% <100.00%> (+0.55%) ⬆️
python_version3.9-sqlalchemy1.4-noasyncpg-noaws_rds_iam 75.74% <100.00%> (+0.55%) ⬆️
python_version3.9-sqlalchemy2.0-asyncpg-aws_rds_iam 96.03% <66.66%> (-0.24%) ⬇️
python_version3.9-sqlalchemy2.0-asyncpg-noaws_rds_iam 94.05% <66.66%> (-0.24%) ⬇️
python_version3.9-sqlalchemy2.0-noasyncpg-aws_rds_iam 76.98% <66.66%> (-0.20%) ⬇️
python_version3.9-sqlalchemy2.0-noasyncpg-noaws_rds_iam 75.00% <66.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fastapi_sqla/sqla.py 100.00% <100.00%> (ø)

@hadrien hadrien merged commit cca6a72 into master May 5, 2023
@hadrien hadrien deleted the fix/DIA-55287/DeclarativeBase branch May 5, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants