Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GH Actions for testing Windows support. #40

Merged
merged 2 commits into from Oct 30, 2023

Conversation

tmcgilchrist
Copy link
Collaborator

This will test whether grpc with lwt and Eio support builds on Windows.

Opening as a Draft while I validate the tutorial code works on Windows.

@tmcgilchrist tmcgilchrist marked this pull request as ready for review October 25, 2023 21:48
@tmcgilchrist
Copy link
Collaborator Author

This seems to be working well enough in my local testing to enable it for the main repo. The situation with opam-repository packages and Windows support is evolving and should improve when opam.2.2 is generally available.

@tmcgilchrist tmcgilchrist merged commit 864ce01 into dialohq:main Oct 30, 2023
3 checks passed
@quernd
Copy link
Collaborator

quernd commented Nov 3, 2023

Thanks @tmcgilchrist!
CI was green when you added your commits but we inadvertently broke it (in #43 I believe). I opened #47 to address this.

@tmcgilchrist
Copy link
Collaborator Author

Thank you for picking that up and sorry about breaking things. @quernd

@tmcgilchrist tmcgilchrist deleted the windows branch December 18, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants