chore: fix removing template from source loader in the docs #495
Conversation
|
Thanks for contributing to Dialtone Vue! Please read below for some important info regarding Vue 3 compatibility. Currently we need to maintain two branches in Dialtone Vue, one for Vue 2, one for Vue 3. This means you must create two PRs for every feature change you make. One into Many times the change you have made in Vue 2 will be identical to the change you need to make in Vue 3. To make this easier we have made a script that can copy your changes from this branch to a new branch off of staging-vue3 suffixed with -vue3. run Once the new branch is created, you will need to look at your code to make sure it still makes sense and test that your changes all work in vue 3. If everything is good you can push it and create a PR into It is a required check for every PR to have a corresponding branch called I got "commit SHA is a merge but no -m option was given."This happens if there are merge commits in your branch. It's no problem, you can simply skip them with What if I make more changes to my vue 2 branch after running ./copy_pr_vue3.sh?You can copy these to the existing -vue3 branch by running the script with a git SHA param like so:
where 2a78db7 is the last commit from your branch that was copied to the other branch (all commits after this will be copied) If it's just one or two commits, you may prefer to just manually use What if I get a conflict?It's possible to get a conflict when running |
|
✔️ Deploy Preview ready! |
| transformSource(src) { | ||
| const match = /^<template>(.*)<\/template>/.exec(src) | ||
| if(match) { | ||
| return match[1] | ||
| } | ||
| return src | ||
| } |
There was a problem hiding this comment.
What happens if we just remove this completely? Wondering if they fixed this in an update.
There was a problem hiding this comment.
It's still needed in the current Storybook version we're using (6.5.7). Worth to try to remove once we update to newer versions.
|
🎉 This PR is included in version 2.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fix removing template from source loader in the docs
🛠️ Type Of Change
📖 Description
This fixes the error that breaks the docs page when clicking in Show code button in a story (for now only available when switching from stories of the same component or resetting controls from the "Slots, Props & Events" table).
To fix the bug that the "Show code" button is not available and instead shows "No code available", an issue was created in the Storybook repository https://github.com/storybookjs/storybook/issues/19160.
Storybook 7.0 is still in alpha version and seems to be unstable for upgrading. In the 6.5.10 version (latest stable version) the bug is still present so upgrading is not a solution for now.
The workaround is to use iframe stories but unfortunately generates other problems (performance, iframes that needs to be adjusted individually).
💡 Context
📝 Checklist
🔮 Next Steps
Track the issue in Storybook to see if they come up with a solution or figure out the problem ourselves in the Sb's code to see if we can fix (I have a rough idea about where to look for the issue).
📷 Screenshots / GIFs
2022-09-12.at.11.56.28.mp4
🔗 Sources