-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use CodeExampleTabs from badge to button-group #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Had a quick look will review more thoroughly tomorrow.
re the 2 space indentation thing.. I was having trouble getting this working.. maybe this? https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md010---hard-tabs |
sure, lemme see if I can add it quickly if it not, I will create a jira ticket to tackle it later. |
Okay I added it, but seems like it does not interact inside our codeBlocks Screen.Recording.2024-03-06.at.11.52.13.movTo test it, im using https://www.npmjs.com/package/eslint-plugin-markdownlint
|
✔️ Deploy previews ready! |
Okay, should be ok to review it. |
Hmm yeah thought that might happen, maybe we can do a separate story for this one. |
Jira ticket: https://dialpad.atlassian.net/browse/DLT-1600 |
# [9.18.0](dialtone/v9.17.0...dialtone/v9.18.0) (2024-03-07) ### Bug Fixes * message input issues ([#190](#190)) ([caa07b6](caa07b6)) * remove markRaw ([#191](#191)) ([74884e2](74884e2)) ### Documentation * use CodeExampleTabs from badge to button-group ([#185](#185)) ([808015b](808015b)) ### Features * **Editor:** add quick replies icon to editor ([#193](#193)) ([7a6829f](7a6829f))
use CodeExampleTabs from badge to button-group
Jira ticket: https://dialpad.atlassian.net/browse/DLT-691
Implemented our new CodeExampleTabs component into:
Images: