fix: remove markRaw

[juliodialpad]

Fix Rich Text editor - Remove markRaw

Obligatory GIF (super important!)

🛠️ Type Of Change

These types will increment the version number on release:

• Fix

📖 Jira Ticket

No Jira ticket

📖 Description

Removed markRaw from vue2 version of DtRichTextEditor plugins as this is exclusive of vue 2.7+ and dialpad is using 2.6.14

💡 Context

Issues implementing DtRecipeMessageInput on dialpad were reported, worked with @bianca-artola-dialpad and found out this markRaw issues.

📝 Checklist

For all PRs:

• I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
• I have reviewed my changes.
• I have considered the performance impact of my change.

🔮 Next Steps

Release and update on product side.

[github-actions]

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-191/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-191/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-191/

[braddialpad]

What exactly are we losing by removing this?

[iropolo]

Huh... why it was there in first place...? @sanjeevdialpad worked out that feature? maybe he has some info

[juliodialpad]

What exactly are we losing by removing this?

This might impact the performance, there is chance that the component could be made reactive and it doesn't need to, that's why it was trying to use markRaw in first place, tried to replace with Object.freeze() but it didn't work.

I didn't see the Vue warning related to component being reactive when I don't need to tho, so I think we're good.

[juliodialpad]

Huh... why it was there in first place...? @sanjeevdialpad worked out that feature? maybe he has some info

markRaw is to create static components that don't need reactivity but it doesn't work on vue 2.6.14

[braddialpad]

Alright let's give er a go