Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button): DLT-1779 add link-inverted prop #343

Merged
merged 2 commits into from
May 31, 2024
Merged

feat(button): DLT-1779 add link-inverted prop #343

merged 2 commits into from
May 31, 2024

Conversation

ninamarina
Copy link
Contributor

@ninamarina ninamarina commented May 31, 2024 •
edited
Loading

feat(button): DLT-1779 add link-inverted prop

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

📖 Jira Ticket

DLT-1779

📖 Description

Adds the prop linkInverted to DtButton to be consistent with the changes made in #321

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have added / updated unit tests.
  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
  • I have validated components with a screen reader.
  • I have validated components keyboard navigation.

🔮 Next Steps

Update Firespotter to use the new prop

📷 Screenshots / GIFs

button-link

@ninamarina ninamarina changed the title feat(button): add link-inverted prop feat(button): DLT-1779 add link-inverted prop May 31, 2024
@github-actions GitHub Actions
Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-343/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-343/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-343/

@ninamarina ninamarina marked this pull request as ready for review May 31, 2024 18:36
braddialpad
braddialpad approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, ty

@braddialpad braddialpad merged commit 6819394 into staging May 31, 2024
10 checks passed
@braddialpad braddialpad deleted the add/link-inverted branch May 31, 2024 22:55
juliodialpad pushed a commit that referenced this pull request May 31, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.42.0
d12e074 
# [9.42.0](dialtone/v9.41.0...dialtone/v9.42.0) (2024-05-31)

### Bug Fixes

* NO-JIRA remove double classes from dialtone output ([#340](#340)) ([0fcea93](0fcea93))
* **Tooltip:** NO-JIRA do not display when empty, general cleanup ([#344](#344)) ([a83d619](a83d619))

### Features

* **Button:** DLT-1779 add link-inverted prop ([#343](#343)) ([6819394](6819394))
* **Emoji Picker:** DLT-1781 allow hiding of search and setting searchQuery via prop ([#345](#345)) ([d5e5373](d5e5373))
juliodialpad pushed a commit that referenced this pull request May 31, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.136.0
2a50832 
# [2.136.0](dialtone-vue2/v2.135.0...dialtone-vue2/v2.136.0) (2024-05-31)

### Bug Fixes

* **Tooltip:** NO-JIRA do not display when empty, general cleanup ([#344](#344)) ([a83d619](a83d619))

### Features

* **Button:** DLT-1779 add link-inverted prop ([#343](#343)) ([6819394](6819394))
* **Emoji Picker:** DLT-1781 allow hiding of search and setting searchQuery via prop ([#345](#345)) ([d5e5373](d5e5373))
juliodialpad pushed a commit that referenced this pull request May 31, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.129.0
e29f485 
# [3.129.0](dialtone-vue3/v3.128.0...dialtone-vue3/v3.129.0) (2024-05-31)

### Bug Fixes

* **Tooltip:** NO-JIRA do not display when empty, general cleanup ([#344](#344)) ([a83d619](a83d619))

### Features

* **Button:** DLT-1779 add link-inverted prop ([#343](#343)) ([6819394](6819394))
* **Emoji Picker:** DLT-1781 allow hiding of search and setting searchQuery via prop ([#345](#345)) ([d5e5373](d5e5373))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ninamarina @braddialpad