fix(tooltip): NO-JIRA do not display when empty, general cleanup #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
|
Please add either the |
5 tasks
|
✔️ Deploy previews ready! |
juliodialpad
approved these changes
May 31, 2024
|
Yeah it was very confusing. Hopefully it makes a bit more sense now. |
juliodialpad
pushed a commit
that referenced
this pull request
May 31, 2024
# [9.42.0](dialtone/v9.41.0...dialtone/v9.42.0) (2024-05-31) ### Bug Fixes * NO-JIRA remove double classes from dialtone output ([#340](#340)) ([0fcea93](0fcea93)) * **Tooltip:** NO-JIRA do not display when empty, general cleanup ([#344](#344)) ([a83d619](a83d619)) ### Features * **Button:** DLT-1779 add link-inverted prop ([#343](#343)) ([6819394](6819394)) * **Emoji Picker:** DLT-1781 allow hiding of search and setting searchQuery via prop ([#345](#345)) ([d5e5373](d5e5373))
juliodialpad
pushed a commit
that referenced
this pull request
May 31, 2024
# [2.136.0](dialtone-vue2/v2.135.0...dialtone-vue2/v2.136.0) (2024-05-31) ### Bug Fixes * **Tooltip:** NO-JIRA do not display when empty, general cleanup ([#344](#344)) ([a83d619](a83d619)) ### Features * **Button:** DLT-1779 add link-inverted prop ([#343](#343)) ([6819394](6819394)) * **Emoji Picker:** DLT-1781 allow hiding of search and setting searchQuery via prop ([#345](#345)) ([d5e5373](d5e5373))
juliodialpad
pushed a commit
that referenced
this pull request
May 31, 2024
# [3.129.0](dialtone-vue3/v3.128.0...dialtone-vue3/v3.129.0) (2024-05-31) ### Bug Fixes * **Tooltip:** NO-JIRA do not display when empty, general cleanup ([#344](#344)) ([a83d619](a83d619)) ### Features * **Button:** DLT-1779 add link-inverted prop ([#343](#343)) ([6819394](6819394)) * **Emoji Picker:** DLT-1781 allow hiding of search and setting searchQuery via prop ([#345](#345)) ([d5e5373](d5e5373))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(tooltip): do not display when empty, general cleanup
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Description
💡 Context
@juliodialpad put up pr #341 yesterday to solve the tooltip not displaying, but the problem was actually that I broke the fix I already made by overriding the onShow method.
📝 Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.shscript. Read docs here: Dialtone Vue Sync Script