Begin deprecation of py.path usage
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 53.93% 54.62% +0.68%
==========================================
Files 6 6
Lines 330 335 +5
==========================================
+ Hits 178 183 +5
Misses 152 152 |
|
This will be deployed and released shortly, pending a few blocking issues as outlined in the DIALS core meeting: |
py.path has been deprecated for a long time, and since we moved to Python 3 there is no reason now to not use the standard library pathlib.Path objects. This commit enables a DeprecationWarning when the pytest fixture does not specify a preferred return object type. A deprecation plan is laid out in HISTORY.rst
Anthchirp
force-pushed
the
begin-py-path-deprecation
branch
from
96c7b16
to
ed70a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py.pathhas been deprecated (rather: "in maintenance mode") for a long time, and since we moved to Python 3 there is no reason now to not use the standard librarypathlib.Pathobjects.This commit enables a
DeprecationWarningwhen the pytest fixture does not specify a preferred return object type.A deprecation plan is laid out in
HISTORY.rst