Fix 1030: keep goniometers and scans around if provided in input #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even for stills - fixes #1030 Test case: ```dials.index imported.expt strong.refl \ max_lattices=3 unit_cell=47,71,102,90,90,90 \ space_group=P222 \ stills.indexer=sequences joint_indexing=0 \ indexing.method=fft1d detector.fix=all beam.fix=all \ outlier.algorithm=tukey``` this made _no_ difference to the text output but kept the goniometer, scan and image sequence correctly in the output.
Side effect of a53f7b1 was to switch the default outlier rejection to tukey, but the test is based on results of using sauter_poon so set this explicitly.
|
Hi, don't merge this yet, if that's ok. I need to think about it. |
|
Sure, though if you have a timescale for taking a look I’d appreciate it 🙂👍
|
|
I've had my think. Ok to merge. I can't think of a use case that is broken from my previous post: I still would like to see a grid scan and its associated headers so I could look a the resultant imported .json file. |
phyy-nx
approved these changes
Dec 17, 2019
|
Thanks @phyy-nx yes we should add some "proper" grid data to the test set for this, probably via zenodo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
N.B. to get original treatment can import images as stills which deletes goniometer and scan from the get go.
These are cherry-picked from #1075