Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a couple of changes to the unit cell tool of
dials.image_viewer
.First, I renamed parameters here to be more consistent with other DIALS programs:
spacegroup
→space_group
andunitcell
→unit_cell
. I suspect this tool is not used much here (whereas it may get much more use incctbx.image_viewer
). Therefore I don't think this change affects many users' existing work patterns.The second change introduces a new parameter,
show_hkl
. This can be used to filter the displayed rings to show only those corresponding to Miller indices in the supplied list. This is helpful because datasheets for diffraction standards usually list only the strongly diffracting rings: https://www.emsdiasum.com/microscopy/technical/datasheet/80044.aspxWith this change only the desired rings are displayed
which is considerably easier to interpret than viewing all rings up to the specified resolution limit