Stop skipping multi-sweep masking tests #1216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests exist for masking multi-sweep data but they have been marked as skipped in the absence of test data in dials/data. Now that those data exist, we can enable the tests.
Also move from
dxtbx.serialize.load
todxtbx.ExperimentList.from_file
.I suspect my somewhat imperfect pytest-fu means I've created a rather cumbersome parametrised fixture here — I might benefit from someone else's eyes on this in particular.
In short, before:
After: