Give option to show reciprocal lattice in crystal frame #1259
Conversation
When mapping, optionally combine the crystal U matrix with the fixed goniometer matrix - if no crystal model will do nothing
which proves to be trivial as we just want B
|
This looks useful, but I wonder if there is a better label than "Show in crystal frame"? A toggle or radio button between setting = UB and setting = B would be more explanatory (at least to me) |
|
@dagewa I would think to ${average user} "Show in crystal frame" would make more sense than "setting=UB / B" but I welcome other viewpoints. |
|
BTW I recognise that the "setting = B / UB" is much more precise and explicit a definition, no worries. I just think it will not be clear to our end user what this means 馃檪 |
|
I do think this is a more expert option, the users of which should probably know what a setting matrix is. I'm also imagining adding another option in future to include RUB and then have an angle control. This would allow visualisation of the orientation of the crystal wrt to the beam at any image and thus address #214 |
|
I am not wedded to the name, but I would like to get the feature in. I personally think this is not an expert option - I could see in situ general users using it... |
|
This is particularly cute when you are looking at > 1 lattice on a sweep as they can be overlapped rather nicely - example with 2 -
becomes
|
Co-authored-by: Markus Gerstel <2102431+Anthchirp@users.noreply.github.com>
Rolled into the treatment of fixed_rotation which is renamed to sample rotation - could probably pull those bits out of the panel loop, but things OK like this for the moment
|
The tooltip doesn't appear to be working for me, on Linux :-( |
Works on RHEL7 for me, and macOS:
Please excuse the Moire patterns - I could not do a screen grab without making the tooltip vanish 馃檮 |
|
I believe it works! Just not on my laptop 馃し |
|
|
|
Please can I merge this? Was looking for exactly this feature a second ago. Or are the absence of tooltips on some systems a blocker? |
|
Fine by me |
When mapping, optionally combine the crystal U matrix with the fixed goniometer matrix - if no crystal model will do nothing * Show reciprocal points in crystal frame * Show cell axes in same frame * Add long form prose as tooltip to explain what this means Co-authored-by: Markus Gerstel <2102431+Anthchirp@users.noreply.github.com>
|
N.B. also needed a985e1b |
When mapping, optionally combine the crystal U matrix with the fixed goniometer matrix - if no crystal model will do nothing * Show reciprocal points in crystal frame * Show cell axes in same frame * Add long form prose as tooltip to explain what this means Co-authored-by: Markus Gerstel <2102431+Anthchirp@users.noreply.github.com>
* fix reading of single-image Eiger files (cctbx/dxtbx#164) * we now support Spring2020 Nexus files, including multi-wavelength beams and absence of goniometer/scan (dials/dxtbx#41) * project names are now correctly written into .mtz files * dials.reciprocal_lattice_viewer: show correct sweep colour for integrated data (#1283) * dials.reciprocal_lattice_viewer: added option to show lattice in crystal frame (#1259) * xia2: fix treatment of missing individual images (xia2/xia2#462, xia2/xia2#463)
- `dials.reciprocal_lattice_viewer`: Add an option to show lattice(s) in the crystal rather than laboratory frame. (#1259) - Support for mtz project_name in export and scaling - `dials.reciprocal_lattice_viewer`: fix multiple experiment view for integrated data (#1284) - cctbx_project: Fix python 3 compatibility in prime - dxtbx: Account for beam centre record changing with ADSC 442 move from 8.3.1 to 5.0.1 (cctbx/dxtbx#171) - dxtbx: Fix handling for hierarchical NeXus detectors (cctbx/dxtbx#175) - dxtbx: Prevent mangling of URL-based filenames via abspath (cctbx/dxtbx#176) - dxtbx: Fix incorrect axis detection on MAX IV Eiger and Spring8 (cctbx/dxtbx#178) - xia2: Fix missing anomalous info in hkl data converted for shelx - xia2: Compatibility with DIALS project_name changes
Contributes to #279
Includes "Crystal frame" toggle, which shows the reciprocal lattice points and reciprocal lattice vectors in the crystal frame i.e.
B*hrather thanU*B*hIllustrations:
Before:
After:
You have to zoom in closely to see differences between reciprocal lattices, but they are there 馃檪