Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor detect_blanks #1288

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Refactor detect_blanks #1288

merged 4 commits into from
Jun 18, 2020

Conversation

rjgildea
Copy link
Contributor

@rjgildea rjgildea commented Jun 4, 2020 •
edited by Anthchirp

  • Move algorithm code to dials/util/detect_blanks.py
  • Add tests - this code wasn't previously explicitly tested
  • In detect blanks, stop gracefully if still; add test

Supersedes and closes #1267

Fixes #1250

@rjgildea
Copy link
Contributor Author

  • Move algorithm code to dials/util/detect_blanks.py
  • Add tests - this code wasn't previously explicitly tested
  • In detect blanks, stop gracefully if still; add test

Supersedes and closes #1267
Fixes #1250

@rjgildea rjgildea merged commit 4ce6081 into master Jun 18, 2020
@rjgildea rjgildea deleted the detect_blanks branch June 18, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme-winter graeme-winter Awaiting requested review from graeme-winter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dials.detect_blanks crashes if given images with 0 oscillation
2 participants
@rjgildea @graeme-winter