Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users should not see stack trace #1325

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Conversation

graeme-winter
Copy link
Contributor

No description provided.

@graeme-winter graeme-winter marked this pull request as ready for review July 6, 2020 14:33
@graeme-winter
Copy link
Contributor Author

For future reference - was getting

Insufficient reflections (14 < 250) to perform error modelling.
Traceback (most recent call last):
  File "/Users/graeme/svn/cctbx/modules/dials/algorithms/scaling/scaler.py", line 212, in perform_error_optimisation
    self.params.weighting.error_model, Ih_table
  File "/Users/graeme/svn/cctbx/modules/dials/algorithms/scaling/error_model/engine.py", line 36, in run_error_model_refinement
    model = model_class(Ih_table.blocked_data_list[0], scope)
  File "/Users/graeme/svn/cctbx/modules/dials/algorithms/scaling/error_model/error_model.py", line 365, in __init__
    Ih_table, basic_params, min_partiality
  File "/Users/graeme/svn/cctbx/modules/dials/algorithms/scaling/error_model/error_model.py", line 410, in filter_unsuitable_reflections
    min_reflections_required=cls.min_reflections_required,
  File "/Users/graeme/svn/cctbx/modules/dials/algorithms/scaling/error_model/error_model.py", line 565, in filter_unsuitable_reflections
    % (n, min_reflections_required)
ValueError: Insufficient reflections (14 < 250) to perform error modelling.

which I think is not user friendly

@graeme-winter
Copy link
Contributor Author

Now

8 outliers have been identified. 

Insufficient reflections (14 < 250) to perform error modelling.
Components to be refined in this cycle for all datasets: scale, decay
Performing a round of scaling with a Levenberg-Marquardt minimizer.

@graeme-winter graeme-winter changed the title Users no see stack trace Users should not see stack trace Jul 7, 2020
@graeme-winter graeme-winter merged commit 9027771 into master Jul 7, 2020
@Anthchirp Anthchirp deleted the hide-scale-stack-trace branch October 30, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants