deltacchalf filtering: allow image_group mode on single data set #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works, and seems to be a valid thing to do, so don't prohibit it. Only catch whole data set deltacchalf mode, which won't work on a single data set (obviously).
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
==========================================
+ Coverage 64.19% 64.22% +0.02%
==========================================
Files 617 617
Lines 69784 69797 +13
Branches 9557 9557
==========================================
+ Hits 44801 44827 +26
+ Misses 23215 23207 -8
+ Partials 1768 1763 -5
Continue to review full report at Codecov.
|
jbeilstenedmands
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Thanks for sorting this out, looks good.
This wants linking to #1161 when merging in.
rjgildea
added a commit
that referenced
this pull request
Jul 13, 2020
It works, and seems to be a valid thing to do, so don't prohibit it. Only catch whole data set deltacchalf mode, which won't work on a single data set (obviously). Fixes #1161
rjgildea
added a commit
that referenced
this pull request
Jul 15, 2020
It works, and seems to be a valid thing to do, so don't prohibit it. Only catch whole data set deltacchalf mode, which won't work on a single data set (obviously). Fixes #1161
Merged
ndevenish
added a commit
that referenced
this pull request
Jul 20, 2020
- `dials.scale`: Allow usage of `mode=image_group` with `filtering.method=deltacchalf` when only providing a single data set (#1334) - `dials.import`: When using a template and specifying an image_range, missing images outside of the range will not cause a failure (#1333) - `dials.stills_process`: Show better error message in specific spotfinding failure case (#1180)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works, and seems to be a valid thing to do, so don't prohibit it. Only catch whole data set deltacchalf mode, which won't work on a single data set (obviously).
Fixes #1161