Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot_reflections #1346

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Fix plot_reflections #1346

merged 5 commits into from
Jul 22, 2020

Conversation

rjgildea
Copy link
Contributor

Don't plot white circles with white edges on a white background.

Don't plot white circles with white edges on a white background.
@rjgildea rjgildea requested a review from Anthchirp July 21, 2020 09:31
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #1346 into master will increase coverage by 0.10%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
+ Coverage   64.22%   64.32%   +0.10%     
==========================================
  Files         616      616              
  Lines       69811    69806       -5     
  Branches     9536     9536              
==========================================
+ Hits        44834    44906      +72     
+ Misses      23211    23113      -98     
- Partials     1766     1787      +21     
Impacted Files Coverage Δ
command_line/plot_reflections.py 61.01% <92.85%> (+61.01%) ⬆️
test/test_plot_reflections.py 100.00% <100.00%> (+55.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22751e...02e2201. Read the comment docs.

Copy link
Member

@Anthchirp Anthchirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. I'll add a commit to update the test though

@Anthchirp Anthchirp linked an issue Jul 22, 2020 that may be closed by this pull request
@rjgildea rjgildea merged commit e7e5292 into master Jul 22, 2020
@rjgildea rjgildea deleted the fix-plot-reflections branch July 22, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dials.plot_reflections - what does it do?
2 participants