No more abc #1365
Merged
No more abc #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthchirp
approved these changes
Aug 3, 2020
Only crystal parameterisations currently set state uncertainties. Others (detector, beam, etc.) simply pass here
Codecov Report
@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
- Coverage 64.62% 64.61% -0.02%
==========================================
Files 616 616
Lines 69852 69831 -21
Branches 9542 9542
==========================================
- Hits 45142 45121 -21
Misses 22937 22937
Partials 1773 1773 |
rjgildea
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 6 instances of
__metaclass__ = abc.ABCMetaremaining in DIALS. This PR removes these and the associated decorators on abstract methods. It is easier to see what is going on if base class methods simply raiseNotImplementedErrorrather than using obscure metaclass trickery and decorators. As pointed out in #1364, this was also not doing anything useful on Python 3.