dials.stills_process updates #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overwritting it Overwriting the detector means changes in the format class that don't affect the panel positions are lost. Case in point, the original reference geometry for the SACLA MPCCD test that is part of test_stills_process has a gain of 1 and a high saturation value. The current format class indicates the gain is 10 and caps the trusted range lower. To use these values and still use the refined panel positions, it is better to sync recursively the detector frames than to overwrite the detector. This causes the spotfinding parameters for the SACLA MPCCD test to change and actually integrates all 4 images (instead of 3) from the test set.
This limits the percent of events to process to the specified number. Useful when computing resources can't keep up with fast feedback requirements. (features from xtc_process continue to trickle into dials.stills_process :)
|
Don't feel the need for a review on this. Will merge when tests pass. |
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
- Coverage 64.69% 64.65% -0.04%
==========================================
Files 617 617
Lines 69587 69630 +43
Branches 9550 9561 +11
==========================================
+ Hits 45018 45019 +1
- Misses 22787 22829 +42
Partials 1782 1782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements from recent beamtime.