Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a more complete help_message for dials.merge #1413

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Sep 18, 2020

The main motivation here is that the single line help_message does not contain a newline, hence the output of dials.merge with no arguments is messy.

Make the epilogue message multi-line by adding some examples.

The main motivation here is that the single line help_message does
not contain a newline, hence the output of `dials.merge` is messy.
Make the epilogue message multiline by adding some examples.
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1413 into master will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
- Coverage   64.65%   64.44%   -0.21%     
==========================================
  Files         617      617              
  Lines       69630    70079     +449     
  Branches     9561     9718     +157     
==========================================
+ Hits        45019    45164     +145     
- Misses      22829    23119     +290     
- Partials     1782     1796      +14     

@ndevenish
Copy link
Member

All looks good!

@ndevenish ndevenish merged commit c4e9022 into master Sep 28, 2020
@Anthchirp Anthchirp deleted the merge-epilogue branch September 28, 2020 10:43
ndevenish pushed a commit that referenced this pull request Sep 28, 2020
The main motivation here is that the single line help_message does
not contain a newline, hence the output of `dials.merge` is messy.
Make the epilogue message multiline by adding some examples.
@ndevenish ndevenish mentioned this pull request Sep 28, 2020
ndevenish added a commit that referenced this pull request Sep 28, 2020
- ``dials.integrate``: fix integrator=3d_threaded crash if njobs > 1 (#1410)
- ``dials.integrate``: Check for and show error message if shoebox data is missing (#1421)
- ``dials.refine``: Avoid crash for experiments with zero reflections if the `auto_reduction.action=remove` option was active (#1417)
- ``dials.merge``: improve help message by adding usage examples (#1413)
- ``dials.refine``: More helpful error message when too few reflections (#1431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants