Change test for #1410 to use dials-data #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verified that the test fails against the original, unfixed code. This will not work out-of-the-box, as the indexed.* files need to be added to dials-data first. [skip ci]
jbeilstenedmands
approved these changes
Sep 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
+ Coverage 64.65% 65.32% +0.67%
==========================================
Files 617 617
Lines 69639 69728 +89
Branches 9561 9572 +11
==========================================
+ Hits 45022 45547 +525
+ Misses 22836 22346 -490
- Partials 1781 1835 +54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbeilstenedmands In #1410 you added a test that codecov complained about. This is because dials-regression tests are not run on Azure.
I've amended the test to run with a dials-data dataset instead. Are you happy with these changes?
(The test will not work right now, as the
centroid-test-datadataset does not currently includeindexed.*files, so if you're happy I'll add those first)