Make sys.exit messages show red in terminal #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces show_mail_on_error with show_mail_handle_errors.
Anthchirp
approved these changes
Sep 22, 2020
Co-authored-by: Markus Gerstel <2102431+Anthchirp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging shows errors in red now, but calls to
sys.exitbypassed this. In this pull, this is corrected by the standard dials context wrapper, previously used to show the mail message to users.I've called the new function
show_mail_handle_errorsinstead ofshow_mail_on_errorbecause it's starting to do more work than just mail notice handling, and I thought that the scope of what it actually does had crept up enough that the name is confusing.I'm open to suggestions for better names.
(The most important changes are in
util/__init__.py)