Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default separate_panels=False #1424

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Change default separate_panels=False #1424

merged 3 commits into from
Oct 14, 2020

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Sep 23, 2020

When separate_panels=True, outlier rejection is performed for each panel
separately prior to refinement. This is appropriate when we expect the
data on each panel to be drawn from different distributions (for example
prior to metrology corrections). However, it causes a large increase in
the execution time of refinement - dominating the overall job time for
a test case using data from I23.

This parameter should be set to true when doing metrology refinement,
but for normal data processing use, false is likely to be acceptable.

When separate_panels=True, outlier rejection is performed for each panel
separately prior to refinement. This is appropriate when we expect the
data on each panel to be drawn from different distributions (for example
prior to metrology corrections). However, it causes a large increase in
the execution time of refinement - dominating the overall job time for
a test case using data from I23.

This parameter should be set to true when doing metrology refinement,
but for normal data processing use, false is likely to be acceptable.
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1424 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
- Coverage   65.29%   65.27%   -0.03%     
==========================================
  Files         617      617              
  Lines       69621    69617       -4     
  Branches     9560     9558       -2     
==========================================
- Hits        45460    45443      -17     
- Misses      22324    22334      +10     
- Partials     1837     1840       +3     

@phyy-nx
Copy link
Member

phyy-nx commented Sep 23, 2020

This parameter should be set to true when doing metrology refinement, but for normal data processing use, false is likely to be acceptable.

This comment made me want to verify how we are using it in xfel land. And yah, it's set to True for metrology refinement:
https://github.com/cctbx/cctbx_project/blob/master/xfel/command_line/cspad_cbf_metrology.py#L101

Whereas for ensemble refinement (which refines the detector as a whole for batches of data), it's set to False:
https://github.com/cctbx/cctbx_project/blob/master/xfel/command_line/striping.py#L141

@dagewa
Copy link
Member Author

dagewa commented Sep 23, 2020

That seems right. It makes sense to do the same for scans as stills too.

@dagewa
Copy link
Member Author

dagewa commented Oct 14, 2020

@rjgildea are you happy with this for I23 processing?

Copy link
Contributor

@rjgildea rjgildea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a sensible change. Unless you are explicitly doing metrology refinement, it seems sensible to assume that the metrology is sufficiently close to reality that all centroids come from the same distribution. It certainly makes a notable difference to the runtime in some cases.

@dagewa dagewa merged commit 013b144 into master Oct 14, 2020
@Anthchirp Anthchirp deleted the separate_panels==false branch October 27, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants