A more helpful error message for dials.refine #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1431 +/- ##
=======================================
Coverage 65.31% 65.32%
=======================================
Files 617 617
Lines 69650 69650
Branches 9557 9557
=======================================
+ Hits 45495 45497 +2
+ Misses 22322 22321 -1
+ Partials 1833 1832 -1 |
ndevenish
pushed a commit
that referenced
this pull request
Sep 28, 2020
Display a more helpful error message when there are too few reflections to refine.
Merged
ndevenish
added a commit
that referenced
this pull request
Sep 28, 2020
- ``dials.integrate``: fix integrator=3d_threaded crash if njobs > 1 (#1410) - ``dials.integrate``: Check for and show error message if shoebox data is missing (#1421) - ``dials.refine``: Avoid crash for experiments with zero reflections if the `auto_reduction.action=remove` option was active (#1417) - ``dials.merge``: improve help message by adding usage examples (#1413) - ``dials.refine``: More helpful error message when too few reflections (#1431)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.