Modernise precommit script #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove Python2/3 bridging capability * embrace conda * modernize code
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
- Coverage 65.31% 65.19% -0.13%
==========================================
Files 617 615 -2
Lines 69650 70027 +377
Branches 9557 9740 +183
==========================================
+ Hits 45495 45657 +162
- Misses 22322 22502 +180
- Partials 1833 1868 +35 |
Anthchirp
added a commit
that referenced
this pull request
Oct 7, 2020
Anthchirp
added a commit
that referenced
this pull request
Oct 7, 2020
dagewa
pushed a commit
that referenced
this pull request
Oct 14, 2020
dagewa
pushed a commit
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove Python2/3 bridging capability
The previous script allowed running an internal Python 3.6 installation so black could be used even with a Python 2.7 base installation. Since we now only support 3.6+ developer installs this entire logic can be scrapped. Existing developer installations should not be affected.
embrace conda
Similarly, we only support the precommit installation logic in a conda environment. If you have your own setup then you can set up pre-commits manually, but this use case will no longer be supported by our automated precommit setup. Again, existing setups will not be affected.
modernize code
lru_cache. pathlib. f-strings!