Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine masking logger calls #1446

Merged
merged 4 commits into from
Oct 12, 2020
Merged

Combine masking logger calls #1446

merged 4 commits into from
Oct 12, 2020

Conversation

rjgildea
Copy link
Contributor

@rjgildea rjgildea commented Oct 7, 2020

  • Combine up to six consecutive logger.info() calls into a single call
  • Change to debug-level log messages

@graeme-winter
Copy link
Contributor

👍

graylog2 also says thank you

@rjgildea
Copy link
Contributor Author

rjgildea commented Oct 7, 2020

Tested with:

$ dials.generate_mask $(dials.data get -q centroid_test_data)/*0001.cbf d_min=2 d_max=10 resolution_range=4,4.5 untrusted.rectangle=100,200,100,200 untrusted.circle=100,100,10 border=10 polygon=100,100,100,200,200,200,200,100 ice_rings=True -vv

@ndevenish
Copy link
Member

I've argued myself in circles over whether the concatenation makes sense so am going agnostic

@rjgildea rjgildea merged commit 4e2653e into master Oct 12, 2020
@rjgildea rjgildea deleted the masking-combine-logging branch October 12, 2020 11:42
dagewa pushed a commit that referenced this pull request Oct 14, 2020
* Combine up to six consecutive logger.info() calls into a single call
* Change to debug-level log messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants