Correct some more wxPython deprecations #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndevenish points out that there are yet more covered by https://github.com/ndevenish/dials-fork/tree/imageview, which might be worth adding to this PR. |
|
That's my "hot" WIP branch so both these will be merged in soon :) |
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
==========================================
+ Coverage 65.68% 65.69% +0.01%
==========================================
Files 614 614
Lines 69530 69525 -5
Branches 9517 9516 -1
==========================================
+ Hits 45670 45674 +4
+ Misses 22022 22014 -8
+ Partials 1838 1837 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @dermen, I should have reviewed #1462 but I haven't had my eyes on DIALS in the last couple of weeks. I made a similar set of changes, along with correcting some other wxPython deprecations, in #1387, but that PR never got merged because I over-reached in my proposed changes to the image viewer and it ended up conflicting with XFEL requirements. I've cherry-picked out the relevant commits here, to serve as an addition to #1462.