-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows builds to Azure #1469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this doesn't produce working Windows builds yet, but lays some groundwork. I had previously prepared these changes in a branch, but they might as well move over into the main repository.
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
- Coverage 65.81% 65.61% -0.21%
==========================================
Files 614 614
Lines 69410 69817 +407
Branches 9508 9674 +166
==========================================
+ Hits 45685 45811 +126
- Misses 21887 22159 +272
- Partials 1838 1847 +9 |
So: this works. Few caveats:
|
Anthchirp
changed the title
Improve Windows bootstrap support
Add Windows builds to Azure
Oct 28, 2020
Anthchirp
force-pushed
the
prepare-windows-bootstrap
branch
from
November 2, 2020 12:06
87720d7
to
bff26fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this doesn't produce working Windows builds yet, but lays some
groundwork. I had previously prepared these changes in a branch,
but they might as well move over into the main repository.
With 3.2 branched out of the way now seems an good time to touch the bootstrap script.