For MPI, don't use single log file #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
- Coverage 65.81% 65.81% -0.01%
==========================================
Files 614 614
Lines 69410 69411 +1
Branches 9508 9509 +1
==========================================
- Hits 45685 45683 -2
- Misses 21887 21889 +2
- Partials 1838 1839 +1 |
|
Anyone want to review this one? Not super vital. Otherwise I'll merge it tomorrow. |
ndevenish
pushed a commit
that referenced
this pull request
Nov 9, 2020
Changes to prevent writing to a single log file => locking up the FS on cori Co-authored-by: Johannes Blaschke <jpblaschke@lbl.gov>
Merged
ndevenish
added a commit
that referenced
this pull request
Nov 9, 2020
3.2 Branch releases will now use a fixed conda environment. This release is the first to use the same versions of all dependencies as 3.2.0. Bugfixes -------- - ``dials.symmetry``, ``dials.cosym`` and ``dials.two_theta_refine``: Lowered default partiality_threshold from ``0.99`` to to ``0.4``. The previous default could occasionally result in too many reflections being rejected for particularly narrow wedges. (#1470) - ``dials.stills_process`` Improve performance when using MPI by avoiding unnecessary log file writing (#1471) - ``dials.scale``: Fix scaling statistics output of r_anom data. (#1478)
ndevenish
added a commit
that referenced
this pull request
Nov 9, 2020
3.2 Branch releases will now use a fixed conda environment. This release is the first to use the same versions of all dependencies as 3.2.0. Bugfixes -------- - ``dials.symmetry``, ``dials.cosym`` and ``dials.two_theta_refine``: Lowered default partiality_threshold from ``0.99`` to to ``0.4``. The previous default could occasionally result in too many reflections being rejected for particularly narrow wedges. (#1470) - ``dials.stills_process`` Improve performance when using MPI by avoiding unnecessary log file writing (#1471) - ``dials.scale``: Fix scaling statistics output of r_anom data. (#1478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a single log file locks up the file system. We already had log splitting in place, so this change just prevents configuring the log file twice if MPI is enabled.