Minor change to filtering in scaling error model #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62b0ec3 The effect of the filter was that it could occasionally remove too much data if a large error model correction is needed for the dataset.
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
- Coverage 65.57% 65.57% -0.01%
==========================================
Files 614 614
Lines 68956 68952 -4
Branches 9519 9519
==========================================
- Hits 45219 45213 -6
- Misses 21898 21899 +1
- Partials 1839 1840 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't need to filter large deviations any more, as outliers are preremoved after 62b0ec3
The effect of the filter was that it could occasionally remove too much data if a large error model correction is needed for the dataset.