Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials.estimate_resolution: improved error handling #1494

Merged
merged 4 commits into from
Nov 12, 2020

Conversation

rjgildea
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1494 (2176876) into master (eb1600a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1494      +/-   ##
==========================================
+ Coverage   65.57%   65.61%   +0.03%     
==========================================
  Files         614      614              
  Lines       68956    69031      +75     
  Branches     9519     9534      +15     
==========================================
+ Hits        45219    45294      +75     
  Misses      21898    21898              
  Partials     1839     1839              

Copy link
Contributor

@jbeilstenedmands jbeilstenedmands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ dials.estimate_resolution scaled.*
The following parameters have been modified:

input {
  experiments = scaled.expt
  reflections = scaled.refl
}

DIALS (2018) Acta Cryst. D74, 85-97. https://doi.org/10.1107/S2059798317017235
DIALS 3.dev.276-g2176876f8
Read 85 predicted reflections
Selected 22 scaled reflections
Resolution fit against cc_half failed: No reflections left for fitting
$

Nice, I like it!

@rjgildea rjgildea merged commit 02d67d8 into master Nov 12, 2020
@rjgildea rjgildea deleted the estimate_resolution_error_handling branch November 12, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants