Fix broken exclude_images= option in dials.scale #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely to be broken since some scaling flag changes. Improve test to catch and fix. Currently just doesn't do anything.
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
+ Coverage 65.56% 65.57% +0.01%
==========================================
Files 614 614
Lines 68939 68957 +18
Branches 9530 9530
==========================================
+ Hits 45198 45218 +20
+ Misses 21902 21900 -2
Partials 1839 1839 |
jbeilstenedmands
added a commit
that referenced
this pull request
Dec 2, 2020
Likely broken in 3.2 series since some scaling flag changes (#2478b1e146ee2bbc14f57c29ea701ecae36c17a8), currently just doesn't do anything. Improve test to catch and fix.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing user data in the ccp4 workshop today revealed that this is currently broken, likely due to some recent changes to scaling flags, which effective resets the flags right after setting them for exclude_images....
So this change resets the flags as the very first thing. Tests also updated to explicitly check the number of scaled reflections coming out after excluding which would have caught this.