Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Github Action to check for newsfragments #1531

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Conversation

ndevenish
Copy link
Member

This Github Action runs on pull requests, and does two things:

  • Checks for a newsfragment (anything added in newsfragments/). It will fail if this is not present.
  • Looks for newsfragments/XXX.* and renames them to newsfragments/<PR number>.*. This means that you can create a PR with a placeholder newsfragment without having to go back to the repository, edit and push a new one.

ndevenish and others added 3 commits January 5, 2021 13:44
This was put in for demonstration, but the trigger will fail
if anyone does a PR from another repository (as secrets are
not available)
@codecov

This comment has been minimized.

@ndevenish ndevenish merged commit 5584654 into master Jan 7, 2021
@ndevenish ndevenish deleted the newsrename branch January 7, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants