dials.background: Fix error writing out file when no display connection available #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the X server isn't configured properly or available, then don't crash when trying to write a file out, in which case it needn't connect to the X server to begin with.
ndevenish
changed the title
Bad X11 connection probably causes much broader problems and isn't something that we need to test specific cases for (if we were insistent about this full test suite with bad display would be a much less intrusive way to verify)
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 616 616
Lines 69195 69198 +3
Branches 9558 9559 +1
=======================================
+ Hits 46130 46132 +2
Misses 21125 21125
- Partials 1940 1941 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins has failed on the new background_plot test because
apparently the X server isn't properly configuredthe connection to the desktop isn't available on mac CII had actually tested a fix to do exactly this before, because when
DISPLAYis set the X server is connected to, even if it doesn't display anything, but had decided my complaint was small and technical and the cost of connecting to the window server was also small (on macOS, when logged in remotely, the X server opens but doesn't display anything). Additionally, forcing theaggbackend causes issues if you want to use the command line tools functionally from a program that wants to.show()plots, so I thought leaving it would be sufficient to avoid problems. C'est la vie. 馃う