Fix unicode logging errors on Windows #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing utf-8 to a file that isn't utf-8 encoded causes dials to crash on Windows. Related: xia2/xia2#558
ndevenish
pushed a commit
that referenced
this pull request
Feb 1, 2021
Writing utf-8 to a file that isn't utf-8 encoded causes dials to crash on Windows. Related: xia2/xia2#558
Merged
ndevenish
added a commit
that referenced
this pull request
Feb 1, 2021
Bugfixes -------- - Remove unnecessary call to ``imageset.get_raw_data()`` while generating masks. This was causing performance issues when spotfinding (#1449). - ``dials.export``: Allow data with either summation or profile fitted intensities to be exported. Previously, both were (erroneously) required to be present (#1556). - ``dials.scale``: Fix crash if only summation intensities present and ``intensity_choice=combine`` (#1557). - Fix unicode logging errors on Windows (#1565).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing utf-8 to a file that isn't utf-8 encoded causes dials to
crash on Windows.