-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build #1575
Windows build #1575
Conversation
This SSL issue was with the windows store version of python, right? |
No, it's in the subprocess calls to the executable defined as |
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
=======================================
Coverage 66.71% 66.71%
=======================================
Files 616 616
Lines 69304 69304
Branches 9571 9571
=======================================
Hits 46238 46238
Misses 21134 21134
Partials 1932 1932 |
It turns out that adding conda's DLL directory to PATH during the build was enough to get through with the set up described. There are still many test failures, but I'd rather handle them separately, so marking this as ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dagewa could you have a look if this works for you?
@Anthchirp thanks, can confirm the build works for me. |
I'm working through Windows build errors on this branch (see https://hackmd.io/510HFFicQ7-6yYSUXqHq-A). Still have more to fix, but I wanted to make this visible early (particularly to @Anthchirp), in case there are better approaches. First issue, need this otherwise
import ssl
fails down the line.