Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build #1575

Merged
merged 8 commits into from
Feb 8, 2021
Merged

Windows build #1575

merged 8 commits into from
Feb 8, 2021

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Feb 1, 2021

I'm working through Windows build errors on this branch (see https://hackmd.io/510HFFicQ7-6yYSUXqHq-A). Still have more to fix, but I wanted to make this visible early (particularly to @Anthchirp), in case there are better approaches. First issue, need this otherwise import ssl fails down the line.

@ndevenish
Copy link
Member

This SSL issue was with the windows store version of python, right?

@dagewa
Copy link
Member Author

dagewa commented Feb 1, 2021

No, it's in the subprocess calls to the executable defined as conda_python

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #1575 (88a9621) into master (7dffc8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1575   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files         616      616           
  Lines       69304    69304           
  Branches     9571     9571           
=======================================
  Hits        46238    46238           
  Misses      21134    21134           
  Partials     1932     1932           

@dagewa
Copy link
Member Author

dagewa commented Feb 5, 2021

It turns out that adding conda's DLL directory to PATH during the build was enough to get through with the set up described. There are still many test failures, but I'd rather handle them separately, so marking this as ready now.

@dagewa dagewa marked this pull request as ready for review February 5, 2021 09:39
@Anthchirp Anthchirp self-requested a review February 5, 2021 10:06
Copy link
Member

@Anthchirp Anthchirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagewa could you have a look if this works for you?

@dagewa
Copy link
Member Author

dagewa commented Feb 8, 2021

@Anthchirp thanks, can confirm the build works for me.

@dagewa dagewa merged commit 9711b07 into master Feb 8, 2021
@dagewa dagewa deleted the windows-build branch February 8, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants