Indeterminate normal equations #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the normal equations have some RHS elements equal to zero, list the problematic parameters rather than just complicated-sounding maths
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 66.71% 66.73% +0.01%
==========================================
Files 616 616
Lines 69304 69322 +18
Branches 9571 9574 +3
==========================================
+ Hits 46236 46261 +25
+ Misses 21135 21126 -9
- Partials 1933 1935 +2 |
|
the actual change here is trivial - checking that the newsfragment looks okay |
ndevenish
approved these changes
Feb 17, 2021
ndevenish
pushed a commit
that referenced
this pull request
Feb 18, 2021
When the normal equations have some RHS elements equal to zero, list the problematic parameters rather than just complicated-sounding maths * Set dummy variances for some tests so that weights can be calculated * Allow unindexed reflections to have zero variances
Merged
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Feb 27, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Feb 28, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Mar 1, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Mar 2, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Mar 3, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Mar 4, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Mar 4, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Mar 5, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) - ``dials.reindex``: Write ``.refl`` file output in the default "MessagePack" format for better compatibility with downstream programs (#1616) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
DiamondLightSource-build-server
added a commit
that referenced
this pull request
Mar 5, 2021
Bugfixes -------- - ``dials.import``: Selecting a subset of images with ``image_range=`` now works on stills (#1592) - `dials.search_beam_centre`: Dramatically improved execution time for large data sets (#1612) - ``dials.reindex``: Write ``.refl`` file output in the default "MessagePack" format for better compatibility with downstream programs (#1616) - ``dials.scale``: Fix rare memory crash from infinite loop, that could occur with very bad quality datasets (#1622) Improved Documentation ---------------------- - ``dials.refine``: More informative error message when reflections have weights of zero (#1584)
jbeilstenedmands
added a commit
that referenced
this pull request
Apr 14, 2021
…trix minimisation. Recently introduced as a byproduct of #1584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the normal equations have zero elements on the right hand side, instead of
report