Make symlink optional to fix tests on Windows #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1600 +/- ##
==========================================
+ Coverage 66.62% 66.64% +0.01%
==========================================
Files 614 614
Lines 68725 68763 +38
Branches 9567 9577 +10
==========================================
+ Hits 45789 45824 +35
- Misses 21007 21010 +3
Partials 1929 1929 |
and don't generate warnings
Anthchirp
approved these changes
Feb 20, 2021
dagewa
commented
Feb 22, 2021
| shutil.copy(image, tmp_path) | ||
| yield tmp_path.joinpath("centroid_####.cbf") | ||
| for image in images: | ||
| (tmp_path / image.basename).unlink() |
There was a problem hiding this comment.
The unlink line gave
E PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\fcx32934\\AppData\\Local\\Temp\\pytest-of-fcx32934\\pytest-67\\popen-gw9\\test_template_with_missing_ima1\\centroid_0005.cbf'
in my Windows test run.
There was a problem hiding this comment.
Looks like an intermittent error. Something like Windows file locking at play, perhaps
There was a problem hiding this comment.
I suspect this is us not correctly dealing with file handles (ie. not using context handlers everywhere), leading to a race against the garbage collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows all tests in
test_import.pyto pass on Windows even without Administrator access, or Developer Mode.